Let $X$ be a Banach space, and $M,N$ be two closed subspaces of $X$. We collect several necessary and sufficient conditions for the closedness of $M+N$ ($M+N$ is not necessarily direct sum), and show that a necessary condition in a classical textbook is also sufficient.